.resize does not throw error when options.width or options.height is supplied with float number.

[yqlim]

I'm using version 0.23.0.

When used with width and height as params and supplied with a float number, an error will be thrown:

let width = 30/100;
let height = width;

sharp(buffer)
  .resize(width, height, {
    /* options */
  })

// Throws `Error: Expected positive integer for width but received 0.3 of type number`

However, when the same is written like so, no error will be thrown. It seems that the whole .resize operation is simply skipped:

let width = 30/100;
let height = width;

sharp(buffer)
  .resize({
    width,
    height,
    /* options */
  })

I wasted half my day trying to find what went wrong because my image can never be resized.

According to the documentation, the options.width and options.height take higher priority. So it seems the same error should also be thrown here.

[lovell]

Hi, happy to accept a PR to address this if you're able.

[lovell]

Commit 69fe21a adds unit tests and the logic that would have caught this. Thanks for reporting, this will be in v0.23.1.

[lovell]

v0.23.1 now available.