Linux: ensure GLib's g_print*() functions wrap the system ones
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C99 `printf()` semantics are well-supported by these Linux cross-targets, avoids the need for gnulib compat functions. An alternative is setting up QEMU when cross-compiling, as this functionality is gated by `meson.can_run_host_binaries()`, but this is a bit simpler.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C99
printf()semantics are well-supported by these Linux cross-targets, avoids the need for gnulib compat functions.An alternative is setting up QEMU when cross-compiling, as this functionality is gated by
meson.can_run_host_binaries(), but this is a bit simpler.Note: this is not needed for macOS due to:
https://github.com/GNOME/glib/blob/2.83.3/meson.build#L1204-L1212
(you can verify this by checking for the
GLIB_USING_SYSTEM_PRINTFdefinition inlib/glib-2.0/include/glibconfig.h)Windows binaries, where this was originally found, will be fixed via PR libvips/build-win64-mxe#72 or work-in-progress commit libvips/build-win64-mxe@ea91b64.