Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback on suggested if enacted is not present #345

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

bjorkert
Copy link
Contributor

With this change, the suggested record will be used instead of Fallback on suggested if enacted is not present if Fallback on suggested if enacted is not present is not present.

See discussion in discord/tcd-general.

@bjorkert bjorkert requested a review from dnzxy December 22, 2024 10:37
@bjorkert bjorkert changed the base branch from main to dev December 22, 2024 10:38
@bjorkert
Copy link
Contributor Author

@marionbarker I have been using this for a few days and it has been working well for me. I think we can merge.

@marionbarker
Copy link
Collaborator

This is being used by people who are caregivers. Test that it builds successfully.

Quick test.

  • test phone is running TCD with dana pump using dana simulator
  • set Not Looping alarm for 10 minutes
  • interrupt the simulator and get the audio alarm

@marionbarker marionbarker merged commit 8e44741 into dev Dec 29, 2024
@bjorkert bjorkert deleted the suggested-enacted branch January 2, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants