Use published versions of dependencies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest published versions of `eth-keyring-controller`, `eth-json-rpc-infura`, and `eth-json-rpc-filters` are now used. They in turn are using the latest version of `eth-hd-keyring` and `eth-json-rpc-middleware` respectively.
Gudahtt
commented
Jan 15, 2020
| "eth-hd-keyring@https://github.com/logvik/eth-hd-keyring": | ||
| version "3.5.1" | ||
| resolved "https://github.com/logvik/eth-hd-keyring#0a8ba3351a53e03ad7362714d71287a154f19e47" | ||
| eth-hd-keyring@^3.4.0, eth-hd-keyring@^3.4.1: |
There was a problem hiding this comment.
@logvik For future reference, this was the manual lockfile manipulation I was referring to
As long as the version selected is compatible with all of the ranges asked for, you can edit the lockfile to consolidate them. I don't know of any yarn command that can do this automatically unfortunately, but it's a neat trick.
Sorry I wasn't able to explain it - I don't really have the words for these sections of the lockfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest published versions of
eth-keyring-controller,eth-json-rpc-infura, andeth-json-rpc-filtersare now used. They in turn are using the latest version ofeth-hd-keyringandeth-json-rpc-middlewarerespectively.