Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for Cassette::Cache::NullStore #21

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Add specs for Cassette::Cache::NullStore #21

merged 1 commit into from
Aug 15, 2017

Conversation

rhruiz
Copy link
Member

@rhruiz rhruiz commented Aug 11, 2017

No description provided.

@rhruiz rhruiz requested a review from fabioperrella August 11, 2017 20:21
@rhruiz
Copy link
Member Author

rhruiz commented Aug 11, 2017 •
edited
Loading

Inspired by
https://github.com/rails/rails/blob/master/activesupport/test/cache/stores/null_store_test.rb

@lorn
Copy link
Contributor

lorn commented Aug 14, 2017

You forgot to mention the #20 issue, don't you?

@rhruiz
Copy link
Member Author

rhruiz commented Aug 14, 2017

This fixes half of #20, this still does not test the "switch" to nullstore when activesupport is unavailable because active support is loaded during tests

@rhruiz rhruiz force-pushed the specs-for-null-store branch from 0a5f532 to a62debc Compare August 15, 2017 01:20
@rhruiz rhruiz merged commit 799e64e into master Aug 15, 2017
@americodls americodls mentioned this pull request Aug 21, 2017
Open
@fabioperrella fabioperrella deleted the specs-for-null-store branch June 20, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabioperrella fabioperrella Awaiting requested review from fabioperrella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhruiz @lorn