GEOMESA-2291 CQEngine - handle filter functions, etc #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handles the cases around (in)equalities. Signed-off-by: Jim Hughes <jnh5y@ccri.com>
elahrvivaz
reviewed
Jun 1, 2018
| @@ -259,4 +259,13 @@ object SampleFilters { | |||
| "Who ILIKE 'ADD%'", | |||
| "Who ILIKE '%DA%'" | |||
| ) | |||
|
|
|||
| val functionPredicates: Seq[Filter] = Seq( | |||
| "strConcat(Who, What) = 'Addams1'", | |||
There was a problem hiding this comment.
will this work with multiple AND'd predicates?
There was a problem hiding this comment.
can you add some tests for AND'd predicates of various types?
There was a problem hiding this comment.
Good call.... I just added some tests, and things aren't right...
Signed-off-by: Jim Hughes <jnh5y@ccri.com>
|
I didn't check it in here... but if you want more tests (and some non-determinism to boot!), you can check out this commit: ccri@039f486. |
|
@jnh5y do those extended tests pass? is the non-determinism an issue, or think it's ok to merge? |
|
@elahrvivaz the extended tests pass. The non-determinism comes from the fact that I was generating a random subset of 3-combinations of all the existing filters....;) This should be good to go. |
elahrvivaz
pushed a commit
that referenced
this pull request
Jun 7, 2018
* Handles the cases around (in)equalities. Signed-off-by: Jim Hughes <jnh5y@ccri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Hughes jnh5y@ccri.com