Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbt optics correction #63

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

tbt optics correction #63

wants to merge 2 commits into from

Conversation

elafmusa
Copy link
Collaborator

To do:
-apply_correction function to be replace by SC.set_magnet_setpoints
-Coupling RDTs correction to be added

To do:
-apply_correction function to be replace by SC.set_magnet_setpoints
-Coupling RDTs correction to be added
@SebastienJoly
Copy link
Collaborator

I have rewritten the functions in tbt.py. I tried to remove some redundancy and take advantage of pySC/pyAT functions whenever possible.
Please remember that I now compute the phase advance from the BPM readings and NAFF algorithm. Therefore, the corrections are less effective than with the function at.get_optics but also more realistic. Of course, this is only a first draft from my side, we can still further improve the module!
As the next steps, it would be nice to be able to choose which observables to feed to the function (e.g. phase beating, tune, dispersion, etc) in a generic way. It would allow us to reuse it effortlessly to correct coupling RDTs or other quantities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants