Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM_ENABLE_RUNTIMES=flang-rt for premerge-monolithic-* #396

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

Meinersbur
Copy link
Member

@Meinersbur Meinersbur commented Feb 28, 2025

Update premerge-monolithic-windows and premerge-monolithic-linux to prepare for the removal of the "projects" build of the flang runtime in llvm/llvm-project#124126.

This does not change the actual premerge GitHub action, which is done by llvm/llvm-project#128678

For premerge-monolithic-linux, add flang-rt to the LLVM_ENABLE_RUNTIMES list, indirectly by adding it to depends_on_projects which also updated the build scheduler.

For premerge-monolithic-windows, remove building flang to match the actual pre-merge build which disabled building flang on Windows in llvm/llvm-project@e4b424a. Adding flang-rt would also require compiler-rt (which was always required on Windows, but now there is a regression test for it) and check-compiler-rt is currently failing.

Split off from #333. Verified to work locally using instruction from https://llvm.org/docs/HowToAddABuilder.html#testing-a-builder-config-locally. With the exception of -gmlt which seems to be a Google-only extention of Clang.

Affected builders:

Affected workers:

Admins listed for those workers:

@Meinersbur Meinersbur marked this pull request as ready for review March 3, 2025 09:33
@boomanaiden154 boomanaiden154 requested review from boomanaiden154 and removed request for metaflow March 3, 2025 16:47
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that it's fine for FLANG_RT to be in LLVM_ENABLE_PROJECTS.

@Meinersbur
Copy link
Member Author

LGTM, assuming that it's fine for FLANG_RT to be in LLVM_ENABLE_PROJECTS.

zorg will automatically fill enable_runtimes based on depends_on_projects, unless enable_runtimes is specified explicitly. See also https://github.com/llvm/llvm-zorg/pull/383/files and https://github.com/Meinersbur/llvm-zorg/blob/f43eb12c2f993841905651ca5c14fb50929b55f8/zorg/buildbot/process/factory.py#L65-L66

@boomanaiden154
Copy link
Contributor

Ah, okay. Thanks for the explanation. Seems reasonable enough to me.

@Meinersbur Meinersbur merged commit 3f24306 into llvm:main Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants