Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM_ENABLE_RUNTIMES=flang-rt for OpenMPBuilder builders #389

Merged
merged 1 commit into from
Feb 26, 2025
Merged

LLVM_ENABLE_RUNTIMES=flang-rt for OpenMPBuilder builders #389

merged 1 commit into from
Feb 26, 2025

Conversation

Meinersbur
Copy link
Member

@Meinersbur Meinersbur commented Feb 22, 2025 •
edited
Loading

Add enable_runtimes=['flang-rt'], depends_on_projects=['flang-rt'], and add_lit_checks=['check-flang-rt'] to all OpenMPBuilder-based builders that build flang. This prepares the removal of the "projects" build of the flang runtime in llvm/llvm-project#124126.

Split off from #333

Affected builders:

  • openmp-offload-amdgpu-clang-flang
  • openmp-offload-sles-build-only
  • openmp-offload-rhel-9_4
  • openmp-offload-rhel-8_8

Affected workers:

  • rocm-worker-hw-01 (staging)
  • rocm-worker-hw-04-sles
  • rocm-worker-hw-04-rhel-9_4 (staging)
  • rocm-worker-hw-04-rhel-8_8 (staging)

Admins listed for those workers:

@Meinersbur Meinersbur mentioned this pull request Feb 22, 2025
Draft
@Meinersbur Meinersbur marked this pull request as ready for review February 22, 2025 17:46
jplehr
jplehr approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jplehr jplehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Meinersbur Meinersbur changed the title Make OpenMPBuilder builders use LLVM_ENABLE_RUNTIMES=flang-rt LLVM_ENABLE_RUNTIMES=flang-rt for OpenMPBuilder builders Feb 26, 2025
@Meinersbur Meinersbur merged commit 0ac8f9d into llvm:main Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplehr jplehr jplehr approved these changes

@gkistanova gkistanova Awaiting requested review from gkistanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meinersbur @jplehr