[mlir][sparse] implementating stageSparseOpPass as an interface #69022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeimingLiu
changed the title
PeimingLiu
force-pushed
the
stage-interface
branch
from
7a1cff8 to
11fc430
Compare
yinying-lisa-li
approved these changes
Oct 16, 2023
PeimingLiu
force-pushed
the
stage-interface
branch
from
27ceca6 to
b2418f8
Compare
aartbik
reviewed
Oct 17, 2023
mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
Outdated
Show resolved
Hide resolved
mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.td
Outdated
Show resolved
Hide resolved
aartbik
approved these changes
Oct 17, 2023
added 2 commits
October 17, 2023 17:49
You can test this locally with the following command:git-clang-format --diff 1ebe73821f4cefa48d7e3d24e62303412ab9ad25 115dc30d51c166545846486f70b0ec97b7fa50da -- mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h mlir/lib/Dialect/SparseTensor/IR/SparseTensorInterfaces.cpp mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensor.h mlir/lib/Dialect/SparseTensor/IR/SparseTensorDialect.cpp mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp mlir/lib/Dialect/SparseTensor/Transforms/StageSparseOperations.cppView the diff from clang-format here.diff --git a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
index ebbc522123a5..15f1fa0e5da9 100644
--- a/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
+++ b/mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorInterfaces.h
@@ -1,5 +1,5 @@
//===- SparseTensorInterfaces.h - sparse tensor operations
-//interfaces-------===//
+// interfaces-------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
|
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Oct 20, 2023
Local branch amd-gfx 5dff4b9 Merged main:20af0e5e8d56 into amd-gfx:ca63cea7fda3 Remote branch main 761c9dd [mlir][sparse] implementating stageSparseOpPass as an interface (llvm#69022)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.