[mlir] Add ContractionOpInterface utility functions for vector matrix multiplication #68945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
reviewed
Oct 16, 2023
dcaballe
reviewed
Oct 16, 2023
| /// The test is permutation-invariant. Note that this only checks the affine | ||
| /// maps from an operation, so does not perform any checks on the math being | ||
| /// performed within the reduction. | ||
| bool isBatchMatvec(ArrayAttr indexingMaps); |
There was a problem hiding this comment.
nit: rename to VecMatMul/MatVecMul, VectorMatrixMult/MatrixVectorMult or similar?
There was a problem hiding this comment.
My I kept them as vecmat/matvec since that's what the Linalg op is called. I agree that your version is clearer, but I'm not sure if it's better to stay consistent. Wdyt?
There was a problem hiding this comment.
Yep, fair enough. Thanks!
pzread
approved these changes
Oct 16, 2023
dcaballe
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.