[libc++] Fix UB in <expected> related to "has value" flag (#68552)#68733

Merged

ldionne merged 28 commits intollvm:mainfrom jiixyj:expected-ub

Oct 30, 2023

+534-162

Commits on Oct 30, 2023

[libc++] Fix UB in <expected> related to "has value" flag (llvm#68552 )
jiixyj
committed
replace home-grown constructor tags with standard ones
jiixyj
committed
replace use of ternary operator by explicit if/else
jiixyj
committed
add a short description to the tests
jiixyj
committed
remove comment about memset being UB here
jiixyj
committed
add constructors to __union_t from expected parts and refactor
jiixyj
committed
put new expected<void> test into appropriate folder
jiixyj
committed
disable new tests on compilers that cannot build them
jiixyj
committed
make comment in libcxx/test/std/utilities/expected/types.h more general

jiixyj
and
ldionne
committed
spell out full path to corresponding test file
jiixyj
committed
directly construct into union member instead of trying to delegate to another constructor
jiixyj
committed
remove unneeded '__empty_t' in union of non-void expected
jiixyj
committed
make lambdas automatic variables
jiixyj
committed
rename template parameter from "c" to "constant"

jiixyj
and
ldionne
committed
fix build
jiixyj
committed
add TailClobberer tests for expected.expected
jiixyj
committed
add some missing checks
jiixyj
committed
add tests for expected<void>
jiixyj
committed
fix compile errors
jiixyj
committed
remove declaration of local Except struct
jiixyj
committed
remove more declarations of local Except structs
jiixyj
committed
just return a reference to the union value in emplace()
jiixyj
committed
use LIBCPP_STATIC_ASSERT to check size of std::expected containing a TailClobberer
jiixyj
committed
add swap tests involving TailClobberer
jiixyj
committed
drive by fix: these should be free swaps
jiixyj
committed
make both member.swap.pass.cpp files clang-format friendly
jiixyj
committed
try to avoid -Werror=terminate error on GCC
jiixyj
committed
use if constexpr
jiixyj
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[libc++] Fix UB in <expected> related to "has value" flag (#68552)#68733

Commits on Oct 30, 2023

[libc++] Fix UB in <expected> related to "has value" flag (llvm#68552 )

replace home-grown constructor tags with standard ones

replace use of ternary operator by explicit if/else

add a short description to the tests

remove comment about memset being UB here

add constructors to __union_t from expected parts and refactor

put new expected<void> test into appropriate folder

disable new tests on compilers that cannot build them

make comment in libcxx/test/std/utilities/expected/types.h more general

spell out full path to corresponding test file

directly construct into union member instead of trying to delegate to another constructor

remove unneeded '__empty_t' in union of non-void expected

make lambdas automatic variables

rename template parameter from "c" to "constant"

fix build

add TailClobberer tests for expected.expected

add some missing checks

add tests for expected<void>

fix compile errors

remove declaration of local Except struct

remove more declarations of local Except structs

just return a reference to the union value in emplace()

use LIBCPP_STATIC_ASSERT to check size of std::expected containing a TailClobberer

add swap tests involving TailClobberer

drive by fix: these should be free swaps

make both member.swap.pass.cpp files clang-format friendly

try to avoid -Werror=terminate error on GCC

use if constexpr