Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64] Move LDR_PXI from isStoreToStackSlot to isLoadFromStackSlot #65658

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[AArch64] Move LDR_PXI from isStoreToStackSlot to isLoadFromStackSlot #65658

merged 1 commit into from
Sep 18, 2023

Conversation

weiguozhi
Copy link
Contributor

LDR_PXI is a load instruction, so it should be in isLoadFromStackSlot.

@weiguozhi
[AArch64] Move LDR_PXI from isStoreToStackSlot to isLoadFromStackSlot
ed44ade 
LDR_PXI is a load instruction, so it should be in isLoadFromStackSlot.
@weiguozhi weiguozhi requested a review from a team as a code owner September 7, 2023 19:09
aemerson
aemerson reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@aemerson aemerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this have any effect on codegen?

@weiguozhi
Copy link
Contributor Author

weiguozhi commented Sep 8, 2023 •
edited
Loading

Did this have any effect on codegen?

I haven't observed any in existing code.
But it impacts my work on codegen, more specifically when I try to consider spill/reload in MachineCopyPropagation pass.
These two functions are also used in several other codegen passes.

davemgreen
davemgreen approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me

@weiguozhi weiguozhi merged commit 9a04bc4 into llvm:main Sep 18, 2023
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@weiguozhi @ZijunZhaoCCK
[AArch64] Move LDR_PXI from isStoreToStackSlot to isLoadFromStackSlot (…
91accbd 
…llvm#65658)

LDR_PXI is a load instruction, so it should be in isLoadFromStackSlot.
This was referenced Sep 19, 2023
Closed
Closed
@weiguozhi weiguozhi deleted the LDR_PXI branch October 2, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aemerson aemerson aemerson left review comments

@davemgreen davemgreen davemgreen approved these changes

Assignees
No one assigned
Labels
backend:AArch64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiguozhi @aemerson @davemgreen