Unique stable name reimpl #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2021 08:22
implement the 'act-on' functions.
'Expr' type, which required a ton of implementation... Whew, at least that is over. A couple of 'TODO's remain, but we'll get to those eventually.
|
This repository does not accept pull requests. Please follow http://llvm.org/docs/Contributing.html#how-to-submit-a-patch for contribution to LLVM. |
|
Yikes, sorry! I meant to do this in my own repo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a WIP to keep you guys up to date on my progress.
As of the initial upload, this does the work to the instantiate-attr that needs to be done in order to have a place to mark all of the lambda types. Additionally, it adds the Expr for the builtin-unique-stable-name that we'll need. The CodeGen part doesn't work, and I've not started messing with the mangler yet, but I intend to do that soon.
Don't worry about review, but if you have a 'todo' that you understand better than me, or spot some obvious error, feel free to share!
@schittir Not sure why it won't let me add you as a 'reviewer', but here it is.