Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tblgen rewrite redundant native calls #223

Closed
wants to merge 2 commits into from
Closed

Remove Tblgen rewrite redundant native calls #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e13c3
remove redundant native calls in DRR
AlexandreEichenberger Jun 18, 2020
3e34a9a
Merge branch 'master' into tblgen-rewrite-no-redundant-native-call
AlexandreEichenberger Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mlir/tools/mlir-tblgen/RewriterGen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,9 +1046,9 @@ void PatternEmitter::createAggregateLocalVarsForOpArgs(

for (int argIndex = 0, e = resultOp.getNumArgs(); argIndex < e; ++argIndex) {
if (resultOp.getArg(argIndex).is<NamedAttribute *>()) {
const char *addAttrCmd = "if ({1}) {{"
" tblgen_attrs.emplace_back(rewriter."
"getIdentifier(\"{0}\"), {1}); }\n";
const char *addAttrCmd = "{ if (auto tmpAttr = {1}) "
"tblgen_attrs.emplace_back(rewriter."
"getIdentifier(\"{0}\"), tmpAttr); }\n";
// The argument in the op definition.
auto opArgName = resultOp.getArgName(argIndex);
if (auto subTree = node.getArgAsNestedDag(argIndex)) {
Expand Down