Fix comment typo in ExpandFCOPYSIGN

[RalfJung]

I noticed this while following #111269. It makes little sense that FCOPYSIGN would look at the sign of x, right? Surely this must be y. Also fix the inconsistency where it's sometimes x and sometimes X.

[llvmbot]

@llvm/pr-subscribers-llvm-selectiondag

Author: Ralf Jung (RalfJung)

Changes

I noticed this while following #111269. It makes little sense that FCOPYSIGN would look at the sign of x, right? Surely this must be y. Also fix the inconsistency where it's sometimes x and sometimes X.

---

Full diff: https://github.com/llvm/llvm-project/pull/111489.diff

1 Files Affected:

• (modified) llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (+1-1)

diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
index 42d031310d5e02..5d324f50cce457 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
@@ -1657,7 +1657,7 @@ SDValue SelectionDAGLegalize::ExpandFCOPYSIGN(SDNode *Node) const {
   SDValue SignBit = DAG.getNode(ISD::AND, DL, IntVT, SignAsInt.IntValue,
                                 SignMask);
 
-  // If FABS is legal transform FCOPYSIGN(x, y) => sign(x) ? -FABS(x) : FABS(X)
+  // If FABS is legal transform FCOPYSIGN(x, y) => SignBit(y) ? -FABS(x) : FABS(x)
   EVT FloatVT = Mag.getValueType();
   if (TLI.isOperationLegalOrCustom(ISD::FABS, FloatVT) &&
       TLI.isOperationLegalOrCustom(ISD::FNEG, FloatVT)) {

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[dtcxzyw]

Nice catch! Please fix format before pushing.

[RalfJung]

Format is fixed (I think). Someone else will have to push the "merge" button though.