Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Include guards missing for compression.h #112

Closed
ggreif opened this issue Jan 26, 2020 · 4 comments
Closed

[lldb] Include guards missing for compression.h #112

ggreif opened this issue Jan 26, 2020 · 4 comments
Assignees
Labels

Comments

@ggreif
Copy link
Contributor

ggreif commented Jan 26, 2020

See:

#include <compression.h>

How it should be:

#if defined(HAVE_LIBCOMPRESSION)
#include <compression.h>
#endif

This was detected while updating the nixpkgs for llvm-10.

Similarly

case compression_types::zlib_deflate:
scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_ZLIB);
break;
case compression_types::lzma:
scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_LZMA);
break;
case compression_types::lzfse:
scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_LZFSE);
break;
default:
break;
}
if (scratchbuf_size > 0) {
g_libcompress_scratchbuf = (void*) malloc (scratchbuf_size);
g_libcompress_scratchbuf_type = compression_type;
}
}
if (compression_type == compression_types::lz4) {
compressed_size = compression_encode_buffer(
encoded_data.data(), encoded_data_buf_size,
(const uint8_t *)orig.c_str(), orig.size(),
g_libcompress_scratchbuf,
COMPRESSION_LZ4_RAW);
}
if (compression_type == compression_types::zlib_deflate) {
compressed_size = compression_encode_buffer(
encoded_data.data(), encoded_data_buf_size,
(const uint8_t *)orig.c_str(), orig.size(),
g_libcompress_scratchbuf,
COMPRESSION_ZLIB);
}
if (compression_type == compression_types::lzma) {
compressed_size = compression_encode_buffer(
encoded_data.data(), encoded_data_buf_size,
(const uint8_t *)orig.c_str(), orig.size(),
g_libcompress_scratchbuf,
COMPRESSION_LZMA);
}
if (compression_type == compression_types::lzfse) {
compressed_size = compression_encode_buffer(
encoded_data.data(), encoded_data_buf_size,
(const uint8_t *)orig.c_str(), orig.size(),
g_libcompress_scratchbuf,
COMPRESSION_LZFSE);
}

needs to be adapted.

@ggreif
Copy link
Contributor Author

ggreif commented Jan 28, 2020

This is now https://bugs.llvm.org/show_bug.cgi?id=44690.

ggreif added a commit to ggreif/nixpkgs that referenced this issue Jan 28, 2020
See llvm/llvm-project#112

```
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:715:71: error: use of undeclared identifier 'COMPRESSION_LZ4_RAW'
            scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_LZ4_RAW);
                                                                      ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:718:71: error: use of undeclared identifier 'COMPRESSION_ZLIB'
            scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_ZLIB);
                                                                      ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:721:71: error: use of undeclared identifier 'COMPRESSION_LZMA'
            scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_LZMA);
                                                                      ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:724:71: error: use of undeclared identifier 'COMPRESSION_LZFSE'
            scratchbuf_size = compression_encode_scratch_buffer_size (COMPRESSION_LZFSE);
                                                                      ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:740:13: error: use of undeclared identifier 'COMPRESSION_LZ4_RAW'
            COMPRESSION_LZ4_RAW);
            ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:747:13: error: use of undeclared identifier 'COMPRESSION_ZLIB'
            COMPRESSION_ZLIB);
            ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:754:13: error: use of undeclared identifier 'COMPRESSION_LZMA'
            COMPRESSION_LZMA);
            ^
/tmp/nix-build-lldb-10.0.0-branch.drv-0/lldb-10.0.0-branch/tools/debugserver/source/RNBRemote.cpp:761:13: error: use of undeclared identifier 'COMPRESSION_LZFSE'
            COMPRESSION_LZFSE);
            ^
```
brson pushed a commit to brson/llvm-project that referenced this issue Mar 12, 2022
Rename the M68kOperand::Type enumeration to KindTy to avoid ambiguity
with the Kind field when referencing enumeration values e.g.
`Kind::Value`.

This works around a compilation error under GCC 5, where GCC won't
lookup enum class values if you have a similarly named field
(see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60994).

The error in question is:
`M68kAsmParser.cpp:857:8: error: 'Kind' is not a class, namespace, or enumeration`

Differential Revision: https://reviews.llvm.org/D108723
@RKSimon RKSimon added the lldb label Apr 12, 2022
@llvmbot
Copy link
Member

llvmbot commented Apr 12, 2022

@llvm/issue-subscribers-lldb

@JDevlieghere
Copy link
Member

@JDevlieghere JDevlieghere self-assigned this Apr 12, 2022
@JDevlieghere
Copy link
Member

@ggreif debugserver is only meant to be built on Darwin, where libcompression is always available. I think the right thing to do here is to stop building debugserver on NixOS.

searlmc1 referenced this issue in ROCm/llvm-project Aug 23, 2023
…eanup-whitespaces

Cleanup existing double quote handling
ergawy added a commit to ergawy/llvm-project that referenced this issue Jul 14, 2024
…lvm#112)

Collects values that are local to a loop: "loop-local values". A loop-local
value is one that is used exclusively inside the loop but allocated outside
of it. This usually corresponds to temporary values that are used inside the
loop body for initialzing other variables for example. For a "loop-local" 
value within a loop's scope, localizes that value within the scope of the 
parallel region the loop maps to.
RevySR pushed a commit to revyos/llvm-project that referenced this issue Jul 27, 2024
* [Clang][XTHeadVector] Implement `vmv.v` variants

* [NFC][XTHeadVector] Create dedicated rvv examples

* [Clang][XTHeadVector] Add missing wrappers for vse/vsse

* [Clang][XTHeadVector] Update tests

* [Clang][XTHeadVector] More real-world examples

* [NFC][XTHeadVector] Add QEMU CI

* [NFC][XTHeadVector] Speed up CI compilation

* [NFC][XTHeadVector] Fix ci order

* [NFC][XTHeadVector] Update CI
5chmidti added a commit that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants