Skip to content

Commit

Permalink
[llvm-cxxfilt] De-emphasize "function" in llvm-cxxfilt docs and --help (
Browse files Browse the repository at this point in the history
#113309)

llvm-cxxfilt can demangle names of data symbols, in addition to function
names.

    $ llvm-cxxfilt _ZN6garden5gnomeE
    garden::gnome

And type names too, on request:

    $ llvm-cxxfilt -t i
    int

Update some overly specific the wording in the --help and documentation
that suggests otherwise.
  • Loading branch information
playstation-edd authored Oct 23, 2024
1 parent b225b15 commit d4dd770
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions llvm/docs/CommandGuide/llvm-cxxfilt.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ OPTIONS

.. option:: --quote

Add `"` `"` around demangled function symbols. Do not quote already quoted
symbols.
Add `"` `"` around demangled names. Do not quote already quoted names.

.. option:: --strip-underscore, -_

Expand All @@ -69,7 +68,7 @@ OPTIONS

.. option:: --types, -t

Attempt to demangle names as type names as well as function names.
Attempt to demangle names as type names as well as symbol names.

.. option:: --version

Expand Down
4 changes: 2 additions & 2 deletions llvm/tools/llvm-cxxfilt/Opts.td
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ multiclass Eq<string name, string help> {
}

def help : FF<"help", "Display this help">;
def quote : FF<"quote", "Quote demangled function names with \" \" if not already quoted">;
def quote : FF<"quote", "Quote demangled names with \" \" if not already quoted">;
defm strip_underscore : BB<"strip-underscore", "Strip the leading underscore", "Don't strip the leading underscore">;
def types : FF<"types", "Attempt to demangle types as well as function names">;
def types : FF<"types", "Attempt to demangle types as well as symbol names">;
def no_params : FF<"no-params", "Skip function parameters and return types">;
def version : FF<"version", "Display the version">;

Expand Down

0 comments on commit d4dd770

Please sign in to comment.