Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][Lowering][Bugfix] Refactor for loop lowering #156

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[CIR][Lowering][Bugfix] Refactor for loop lowering #156

merged 1 commit into from
Jul 7, 2023

Conversation

sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Jul 7, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

@sitio-couto
[CIR][Lowering][Bugfix] Refactor for loop lowering
f8bb715 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

[ghstack-poisoned]
This was referenced Jul 7, 2023
Merged
Merged
Merged
sitio-couto added a commit to sitio-couto/clangir that referenced this pull request Jul 7, 2023
@sitio-couto
[CIR][Lowering][Bugfix] Refactor for loop lowering
bef36ad 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm#156
bcardosolopes
bcardosolopes approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sitio-couto sitio-couto merged commit f8bb715 into gh/sitio-couto/38/base Jul 7, 2023
sitio-couto added a commit that referenced this pull request Jul 7, 2023
@sitio-couto
[CIR][Lowering][Bugfix] Refactor for loop lowering
a2e57a8 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
@sitio-couto sitio-couto deleted the gh/sitio-couto/38/head branch July 7, 2023 22:31
lanza pushed a commit that referenced this pull request Oct 27, 2023
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
ac610c5 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
lanza pushed a commit that referenced this pull request Dec 20, 2023
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
b7e9e5a 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
lanza pushed a commit that referenced this pull request Jan 29, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
f392653 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
lanza pushed a commit that referenced this pull request Mar 23, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
a35d86b 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
73d0999 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm#156
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
795bcdb 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
2073e62 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
7487fc1 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm#156
lanza pushed a commit that referenced this pull request Apr 29, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
e6cc9e2 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
612e14e 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm/clangir#156
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
b737195 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm#156
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
af22575 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes llvm#153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: llvm#156
lanza pushed a commit that referenced this pull request Nov 5, 2024
@sitio-couto @lanza
[CIR][Lowering][Bugfix] Refactor for loop lowering
cf0d588 
This refactor merges the lowering logic of all the different kinds of
loops into a single function.

It also removes unnecessary LIT tests that validate LLVM dialect to
LLVM IR lowering, as this functionality is not within CIR's scope.

Fixes #153

ghstack-source-id: ebaab859057a6d81f1978fd88701c28402712562
Pull Request resolved: #156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitio-couto @bcardosolopes