Include response errors in RemoteRecordNotSaved exception #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveh2o
reviewed
Apr 15, 2019
film42
force-pushed
the
gt/add_errors_to_not_saved
branch
from
565c9a6 to
5a03eda
Compare
liveh2o
approved these changes
Apr 16, 2019
|
I was trying to get this in a rails 4.2 app, so I'll get this back-ported once this is merged. |
film42
added a commit
that referenced
this pull request
Apr 16, 2019
film42
added a commit
that referenced
this pull request
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a more correct behavior than:
ActiveRemote::RemoteRecordNotSaved: ActiveRemote::RemoteRecordNotSaved.cc @liveh2o