Refactor attributes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brianstien
commented
Feb 21, 2017
brianstien
commented
- Updates our attribute_assignment module (previously mass_assignment) to mirror rails 5, and also enforce strong params
- Removed attribute defaults, along with their performance issue of calling all public getters on initialization
- Eliminated need for chainable initialization and block initialization is baked in
This brings active_remote in line with rails 4-5. ActiveRemote will now enforce strong params.
Chainable initialization is not necessary now that nothing is overridding initialize. Block initialization functionality is moved into the base initialize method and this will always be enabled, no longer optional.
All codepaths should now be setting this up when we need it. The allocate method will not set up an attributes hash but all the internals using allocate have been made tolerant of this. Anyone manually calling allocate should understand what they are doing.
The ActiveModel implementation of this method is very slow because ActiveModel does not know about our internal attribute storage mechanism. ActiveRecord overrides this method with the implementation here so that this method is fast. By implementing this the same as ActiveRecord, we get a nice perf boost.
liveh2o
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.