Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply some suggestions from Wojtek #3

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Apply some suggestions from Wojtek #3

merged 4 commits into from
Nov 13, 2024

Conversation

philss
Copy link

@philss philss commented Nov 12, 2024 •
edited
Loading

@philss philss marked this pull request as ready for review November 13, 2024 13:42
@philss
Copy link
Author

philss commented Nov 13, 2024

@wojtekmach may I have your bless? :P

wojtekmach
wojtekmach approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@wojtekmach wojtekmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I forgot to subscribe to the repo. :)

@wojtekmach
Update lib/req_ch.ex
d48a892 
Co-authored-by: Wojtek Mach <wojtekmach@users.noreply.github.com>
@philss philss merged commit d095eaa into main Nov 13, 2024
3 checks passed
@philss philss deleted the ps-improvements-from-first-pr branch November 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

@wojtekmach wojtekmach wojtekmach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philss @josevalim @wojtekmach