Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed mkdir to make_path #252

Merged
merged 1 commit into from
Mar 20, 2024
Merged

changed mkdir to make_path #252

merged 1 commit into from
Mar 20, 2024

Conversation

TavorB
Copy link

@TavorB TavorB commented Mar 19, 2024

Thanks for the great codebase. A minor issue that recently came up: the code was failing with error message "failed: 139 at {my_path}/TRUST4/run-trust4 line 55". In the end, it turned out that this was due to me specifying an out directory with --od that didn't exist. This led to an error with the mkdir command:

mkdir $outputDirectory if ( !-d $outputDirectory ) ;
. Modified to use make_path. Thanks again!

@mourisl mourisl merged commit 9fb9699 into liulab-dfci:master Mar 20, 2024
@mourisl
Copy link
Collaborator

mourisl commented Mar 20, 2024

Thank you for the update! The mkdir could not handle recursive directory creation, and your update allows that, which is great! I have merged it to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants