Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with go routines #4754

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

Saranya-jena
Copy link
Contributor

@Saranya-jena Saranya-jena commented Jul 9, 2024

Proposed changes

Fixed issue with goroutines while starting up the server in https/http mode, this issue was introduced here: #4706

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
@Saranya-jena Saranya-jena self-assigned this Jul 9, 2024
@Jonsy13 Jonsy13 merged commit 0b23907 into litmuschaos:master Jul 9, 2024
17 of 18 checks passed
@Jonsy13 Jonsy13 deleted the go-routine-fixes branch July 9, 2024 12:22
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants