-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed k8s client go dependencies from graphql #4747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
…into network-pol
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
shovanmaity
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Jonsy13
reviewed
Jul 8, 2024
data: | ||
DB_SERVER: mongodb://my-release-mongodb-0.my-release-mongodb-headless:27017,my-release-mongodb-1.my-release-mongodb-headless:27017,my-release-mongodb-2.my-release-mongodb-headless:27017/admin | ||
VERSION: "ci" | ||
SKIP_SSL_VERIFY: "false" | ||
# Configurations if you are using dex for OAuth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add Dex config back in both manifests
Jonsy13
approved these changes
Jul 8, 2024
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed imports Signed-off-by: Saranya-jena <saranya.jena@harness.io> * reverted changes for push pipeline Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated go mod Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated mocks Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifests Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed imports Signed-off-by: Saranya-jena <saranya.jena@harness.io> * reverted changes for push pipeline Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated go mod Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated mocks Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifests Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
* removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * Update push.yml * removed k8s client-go dependencies Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * removed token issues Signed-off-by: Saranya-jena <saranya.jena@harness.io> * fixed imports Signed-off-by: Saranya-jena <saranya.jena@harness.io> * reverted changes for push pipeline Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated go mod Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated mocks Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifests Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> * updated manifest Signed-off-by: Saranya-jena <saranya.jena@harness.io> --------- Signed-off-by: Saranya-jena <saranya.jena@harness.io> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removed k8s client go dependencies from graphql server. This enables us to restrict the scope of what graphql server can do regarding interactions with hosts and other system backend services(i.e. k8s). As part of the change, the host IP is now extracted from the HTTP header thus removing the requirement if using client-go to find out the endpoint.
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: