Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace #4680

Calvinaud · 2024-05-30T09:19:07Z

Proposed changes

Split the KubeObject in two to avoid timeout.

Created a new call KubeNamespace to only retrieve the list of namespace
Update KubeObject to retrieve object only in the specified namespace
Fix: Reaching timeout when getting KubeObject on big cluster #4616

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[] New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

…ted) Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update objectmodel and subscriber to incldue KubeNamespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Regenerating model with gqlgen. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Rename getKubeNamespace function that didn't match graphqls operation in Subscription Add missing function for the graphql server to retrieve list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

…space Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

…ince subscriber will only return one element. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

…b workflow Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

…d by trivy. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Fix a comment Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Removing some unused code Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

hrishavjha

FE changes LGTM!

Signed-off-by: Calvinaud <calvinaudier@gmail.com>

- Add some trailing comma - Trying transform subscription function to resolve "non-arrow functions are forbidden" - Add null check Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

- Adding trailing comma - Re-ordering by alphabetic order some parameters Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Jonsy13 · 2024-08-23T06:23:12Z

Hi @Calvinaud , Thanks for this contribution.
Can you please add screenshots validating your changes.

Calvinaud · 2024-08-23T14:22:40Z

Hello

First call that retrieve only the namespace:

Second call that retrieve labels

Docker image used (tag: "separate-call"):

…only a single namespace (litmuschaos#4680) * Create a seperate function to get Namespace in subscriber Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphql server to include KubeNamespace call (model not generated) Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphqls to include KubeNamespace model Update objectmodel and subscriber to incldue KubeNamespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix issue in graphqls and adding KubeNamespace type. Regenerating model with gqlgen. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update model to includude missing field in KubeNamespaceData Rename getKubeNamespace function that didn't match graphqls operation in Subscription Add missing function for the graphql server to retrieve list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Add remaining function in k8s pkg and requests to return list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphql/subscriber to transform KubeObject to not be a array since subscriber will only return one element. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update web server to seperate call for KubeObject and KubeNamespace. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix import with goimports Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Reverting upgrade of webpack-dev-server so it's compatible with github workflow Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Run gofmt with correct version. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Bumping ubi-minimal:8.8 to 8.10 to fix some HIGH CVE severity detected by trivy. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Updating chaos_infrastructure mock to include KubeNamespace. Fix a comment Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix issue from Codacy Removing some unused code Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix codacy issue: - Add some trailing comma - Trying transform subscription function to resolve "non-arrow functions are forbidden" - Add null check Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Continue fix Codacy issue - Adding trailing comma - Re-ordering by alphabetic order some parameters Signed-off-by: Calvin Audier <calvinaudier@gmail.com> --------- Signed-off-by: Calvin Audier <calvinaudier@gmail.com> Signed-off-by: Calvinaud <calvinaudier@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>

…only a single namespace (litmuschaos#4680) * Create a seperate function to get Namespace in subscriber Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphql server to include KubeNamespace call (model not generated) Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphqls to include KubeNamespace model Update objectmodel and subscriber to incldue KubeNamespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix issue in graphqls and adding KubeNamespace type. Regenerating model with gqlgen. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update model to includude missing field in KubeNamespaceData Rename getKubeNamespace function that didn't match graphqls operation in Subscription Add missing function for the graphql server to retrieve list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Add remaining function in k8s pkg and requests to return list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update graphql/subscriber to transform KubeObject to not be a array since subscriber will only return one element. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Update web server to seperate call for KubeObject and KubeNamespace. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix import with goimports Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Reverting upgrade of webpack-dev-server so it's compatible with github workflow Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Run gofmt with correct version. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Bumping ubi-minimal:8.8 to 8.10 to fix some HIGH CVE severity detected by trivy. Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Updating chaos_infrastructure mock to include KubeNamespace. Fix a comment Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix issue from Codacy Removing some unused code Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Fix codacy issue: - Add some trailing comma - Trying transform subscription function to resolve "non-arrow functions are forbidden" - Add null check Signed-off-by: Calvin Audier <calvinaudier@gmail.com> * Continue fix Codacy issue - Adding trailing comma - Re-ordering by alphabetic order some parameters Signed-off-by: Calvin Audier <calvinaudier@gmail.com> --------- Signed-off-by: Calvin Audier <calvinaudier@gmail.com> Signed-off-by: Calvinaud <calvinaudier@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>

Calvinaud added 8 commits May 6, 2024 10:12

Create a seperate function to get Namespace in subscriber

2b2940c

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update graphql server to include KubeNamespace call (model not genera…

9aaf710

…ted) Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update graphqls to include KubeNamespace model

932927a

Update objectmodel and subscriber to incldue KubeNamespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Fix issue in graphqls and adding KubeNamespace type.

5ef43c5

Regenerating model with gqlgen. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update model to includude missing field in KubeNamespaceData

b9cd63e

Rename getKubeNamespace function that didn't match graphqls operation in Subscription Add missing function for the graphql server to retrieve list of namespace Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Add remaining function in k8s pkg and requests to return list of name…

bf77ad3

…space Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update graphql/subscriber to transform KubeObject to not be a array s…

dba1971

…ince subscriber will only return one element. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Update web server to seperate call for KubeObject and KubeNamespace.

59493ad

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Calvinaud marked this pull request as draft May 30, 2024 09:20

Calvinaud changed the title ~~Feature/seperate namespace call~~ Seperate call to retrieve namespace list and only retrieve KubeObject for only a single namespace May 30, 2024

Calvinaud added 6 commits May 30, 2024 11:30

Merge branch 'master' into feature/seperate-namespace-call

b8ec66d

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Fix import with goimports

9f1abf2

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Reverting upgrade of webpack-dev-server so it's compatible with githu…

277678b

…b workflow Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Run gofmt with correct version.

f6cba7b

Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Bumping ubi-minimal:8.8 to 8.10 to fix some HIGH CVE severity detecte…

e31efae

…d by trivy. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Updating chaos_infrastructure mock to include KubeNamespace.

981a147

Fix a comment Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Calvinaud changed the title ~~Seperate call to retrieve namespace list and only retrieve KubeObject for only a single namespace~~ Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace May 30, 2024

Calvinaud marked this pull request as ready for review May 30, 2024 14:31

Fix issue from Codacy

2600fd7

Removing some unused code Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

hrishavjha approved these changes May 31, 2024

View reviewed changes

namkyu1999 and others added 3 commits June 4, 2024 13:25

Merge branch 'master' into feature/seperate-namespace-call

1bf0485

Merge branch 'master' into feature/seperate-namespace-call

179a3d2

Merge branch 'master' into feature/seperate-namespace-call

bdbd3d9

Signed-off-by: Calvinaud <calvinaudier@gmail.com>

namkyu1999 assigned Calvinaud Jun 28, 2024

Calvinaud added 3 commits July 31, 2024 09:39

Merge branch 'master' into feature/seperate-namespace-call

0963f03

Fix codacy issue:

0e3477f

- Add some trailing comma - Trying transform subscription function to resolve "non-arrow functions are forbidden" - Add null check Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Continue fix Codacy issue

785e70c

- Adding trailing comma - Re-ordering by alphabetic order some parameters Signed-off-by: Calvin Audier <calvinaudier@gmail.com>

Saranya-jena requested review from amityt and Jonsy13 August 20, 2024 09:07

Merge branch 'master' into feature/seperate-namespace-call

bcc4a85

Saranya-jena requested a review from SahilKr24 August 23, 2024 06:21

Merge branch 'master' into feature/seperate-namespace-call

ddfa865

amityt approved these changes Sep 6, 2024

View reviewed changes

Jonsy13 approved these changes Sep 6, 2024

View reviewed changes

Merge branch 'master' into feature/seperate-namespace-call

ecb9f78

Saranya-jena merged commit 1165445 into litmuschaos:master Sep 6, 2024
16 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace #4680

Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace #4680

Calvinaud commented May 30, 2024 •

edited

Loading

hrishavjha left a comment

Jonsy13 commented Aug 23, 2024

Calvinaud commented Aug 23, 2024 •

edited

Loading

Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace #4680

Seperate call to retrieve namespace list and retrieve KubeObject for only a single namespace #4680

Conversation

Calvinaud commented May 30, 2024 • edited Loading

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

hrishavjha left a comment

Choose a reason for hiding this comment

Jonsy13 commented Aug 23, 2024

Calvinaud commented Aug 23, 2024 • edited Loading

Calvinaud commented May 30, 2024 •

edited

Loading

Calvinaud commented Aug 23, 2024 •

edited

Loading