-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added strict validation for username and password in backend. #4670
Merged
Saranya-jena
merged 12 commits into
litmuschaos:master
from
aryan-bhokare:backend-validation-username-password
Jun 27, 2024
Merged
Added strict validation for username and password in backend. #4670
Saranya-jena
merged 12 commits into
litmuschaos:master
from
aryan-bhokare:backend-validation-username-password
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aryan <aryan1bhokare@gmail.com>
SahilKr24
reviewed
May 23, 2024
Signed-off-by: aryan <aryan1bhokare@gmail.com>
SahilKr24
reviewed
May 23, 2024
SahilKr24
reviewed
May 23, 2024
bef75aa
to
edaa0cf
Compare
Signed-off-by: aryan <aryan1bhokare@gmail.com>
edaa0cf
to
3d2c6c1
Compare
Signed-off-by: aryan <aryan1bhokare@gmail.com>
Signed-off-by: aryan <aryan1bhokare@gmail.com>
2b85b38
to
2e5b970
Compare
SahilKr24
approved these changes
May 29, 2024
@aryan-bhokare, can you please add an ENV to enable/disable the strict password validation. This ENV (ENABLE_STRICT_PASSWORD_POLICY) will be true by default, i.e. strict password policy check will be implemented, but user can toggle that off based on the use case. |
Jonsy13
reviewed
Jun 19, 2024
Jonsy13
reviewed
Jun 19, 2024
hrishavjha
approved these changes
Jun 19, 2024
Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Signed-off-by: aryan <aryan1bhokare@gmail.com>
Jonsy13
reviewed
Jun 24, 2024
SarthakJain26
approved these changes
Jun 24, 2024
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Signed-off-by: aryan <aryan1bhokare@gmail.com>
SarthakJain26
approved these changes
Jun 27, 2024
Jonsy13
approved these changes
Jun 27, 2024
Saranya-jena
approved these changes
Jun 27, 2024
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Jul 6, 2024
…chaos#4670) * Added strict validation for username and password in backend. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixed silly mistake Signed-off-by: aryan <aryan1bhokare@gmail.com> * some requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * modified tests Signed-off-by: aryan <aryan1bhokare@gmail.com> * small change Signed-off-by: aryan <aryan1bhokare@gmail.com> * Update message string in chaoscenter/authentication/api/handlers/doc.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Update error message chaoscenter/authentication/pkg/utils/sanitizers.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Modified swagger with requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * added negative tests for requested functions and fixed some conflicts. Signed-off-by: aryan <aryan1bhokare@gmail.com> --------- Signed-off-by: aryan <aryan1bhokare@gmail.com> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…chaos#4670) * Added strict validation for username and password in backend. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixed silly mistake Signed-off-by: aryan <aryan1bhokare@gmail.com> * some requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * modified tests Signed-off-by: aryan <aryan1bhokare@gmail.com> * small change Signed-off-by: aryan <aryan1bhokare@gmail.com> * Update message string in chaoscenter/authentication/api/handlers/doc.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Update error message chaoscenter/authentication/pkg/utils/sanitizers.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Modified swagger with requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * added negative tests for requested functions and fixed some conflicts. Signed-off-by: aryan <aryan1bhokare@gmail.com> --------- Signed-off-by: aryan <aryan1bhokare@gmail.com> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
…chaos#4670) * Added strict validation for username and password in backend. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixed silly mistake Signed-off-by: aryan <aryan1bhokare@gmail.com> * some requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * modified tests Signed-off-by: aryan <aryan1bhokare@gmail.com> * small change Signed-off-by: aryan <aryan1bhokare@gmail.com> * Update message string in chaoscenter/authentication/api/handlers/doc.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Update error message chaoscenter/authentication/pkg/utils/sanitizers.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Modified swagger with requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * added negative tests for requested functions and fixed some conflicts. Signed-off-by: aryan <aryan1bhokare@gmail.com> --------- Signed-off-by: aryan <aryan1bhokare@gmail.com> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
…chaos#4670) * Added strict validation for username and password in backend. Signed-off-by: aryan <aryan1bhokare@gmail.com> * fixed silly mistake Signed-off-by: aryan <aryan1bhokare@gmail.com> * some requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * modified tests Signed-off-by: aryan <aryan1bhokare@gmail.com> * small change Signed-off-by: aryan <aryan1bhokare@gmail.com> * Update message string in chaoscenter/authentication/api/handlers/doc.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Update error message chaoscenter/authentication/pkg/utils/sanitizers.go Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> * Modified swagger with requested changes. Signed-off-by: aryan <aryan1bhokare@gmail.com> * added negative tests for requested functions and fixed some conflicts. Signed-off-by: aryan <aryan1bhokare@gmail.com> --------- Signed-off-by: aryan <aryan1bhokare@gmail.com> Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added validation for username and password in backend.
Following #4650
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: