-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ChaosCenter]: Add unit tests to k8s and cluster package in GraphQL server #3971
Merged
imrajdas
merged 7 commits into
litmuschaos:master
from
namkyu1999:add-unit-tests-to-cluster
May 22, 2023
Merged
[ChaosCenter]: Add unit tests to k8s and cluster package in GraphQL server #3971
imrajdas
merged 7 commits into
litmuschaos:master
from
namkyu1999:add-unit-tests-to-cluster
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
…d-unit-tests-to-cluster Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
S-ayanide
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amityt
requested changes
May 19, 2023
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
amityt
approved these changes
May 19, 2023
gdsoumya
approved these changes
May 21, 2023
SohamRatnaparkhi
pushed a commit
to SohamRatnaparkhi/litmus
that referenced
this pull request
Jun 30, 2023
…erver (litmuschaos#3971) * feat: add unit tests to k8s package Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * feat: add unit tests to cluster package Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * fix: fix codacy analysis Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * fix: fix test cases Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * fix: chore Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * fix: rename function Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> --------- Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add unit tests to k8s and cluster package.
I'm using
client-go
fake package so that we don't have to connect actual Kubernetes while unit testing.Overall code coverage is like below
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Issue No. #3892
Special notes for your reviewer: @S-ayanide @amityt