Fix: handle pagination in ssm describeInstanceInformation #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaSami
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Signed-off-by: Sami Shabaneh <sami.shabaneh@careem.com>
ThaSami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an issue where experiments running SSM by tag sometimes report misleading IAM permission errors. The root cause we speculate is the implementation of DescribeInstanceInformation which do not handle pagination. By default the DescribeInstanceInfromation has limited result if the target instance resides on a subsequent page, it won’t be found in the first API response—resulting in an erroneous permission error message or so.
The fix updates the code to use the DescribeInstanceInformationPages to iterate through all pages and correctly aggregate instance information.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #737
Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag