fix: accomodate for pending pods with no IP address in network fault #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ignore pods with no IP address, this can be the case if pod is still in pending state. This will help prevent following error when injecting network fault:
I was considering getting pod IPs from SVC endpoints; however, the RBAC permissions for Chaos Helper pods don't have access to list endpoints, which would likely become a breaking change. We can consider moving to that approach when we plan to rollout the next major version.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Fixes litmuschaos/litmus#4395
Special notes for your reviewer:
Checklist:
breaking-changes
tagrequires-upgrade
tag