Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accomodate for pending pods with no IP address in network fault #684

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

smitthakkar96
Copy link
Contributor

@smitthakkar96 smitthakkar96 commented Jan 22, 2024

What this PR does / why we need it:

Ignore pods with no IP address, this can be the case if pod is still in pending state. This will help prevent following error when injecting network fault:

{"source":"pod-network-corruption-helper-nrb8b","errorCode":"HELPER_ERROR","phase":"ChaosInject","reason":"failed to create destination ips match filters: Illegal \"match\"\n"}

I was considering getting pod IPs from SVC endpoints; however, the RBAC permissions for Chaos Helper pods don't have access to list endpoints, which would likely become a breaking change. We can consider moving to that approach when we plan to rollout the next major version.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes litmuschaos/litmus#4395

Special notes for your reviewer:

Checklist:

  • Fixes #
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

Signed-off-by: smit thakkar <smit.thakkar@deliveryhero.com>
@smitthakkar96
Copy link
Contributor Author

@ispeakc0de @uditgaurav @ksatchit can you please take a look?

@ispeakc0de ispeakc0de merged commit 96f6571 into litmuschaos:master Mar 1, 2024
4 of 8 checks passed
@smitthakkar96 smitthakkar96 deleted the patch-1 branch March 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: pod-network-corruption fails when destination_hosts service pods are in pending state
4 participants