Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve typing error in destriper #272

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Conversation

nraffuzz
Copy link
Contributor

This PR solves the issue #270.

@nraffuzz
Copy link
Contributor Author

Since weights should be an array (field initialized by get_map_making_weights), also obs.net_ukrts should be an array.
In order to handle this I added:

if isinstance(obs.net_ukrts, (float, int)):
    obs.net_ukrts = obs.net_ukrts * np.ones(obs.n_detectors)

inside get_map_making_weights.

I think this PR could be closed.

@ziotom78
Copy link
Member

Looks ok to me. Feel free to update the CHANGELOG and merge this PR!

@nraffuzz nraffuzz merged commit 83ac6aa into master Oct 30, 2023
@nraffuzz nraffuzz deleted the solve_TypingError_in_destriper branch October 30, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants