-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct doc typos #231
correct doc typos #231
Conversation
Few additional comments:
Here a checklist to keep track of this:
|
Thanks! I did some work on this PR to fix the issues you mentioned:
Right, the new image should be clearer: The new text clarifies that the vector e_x has been drawn twice because the one at the top represents the polarization direction in the detector's reference frame, and it's what gets rotated to
Right, they were generated automatically for some ancient version of the file, but they were never updated. Fixed.
Yes, but that's not enough, as If you agree with my changes, we can merge this PR. |
Thank you, Maurizio.
Yes, it is! One last comment: the North direction is along a meridian, not a parallel, right? If so, I can change the word and close the PR.
Thanks, I also removed the last broken "Acknowledgements" link.
Thanks. |
I went through the documentation in
docs/source/
and found some typos, uncorrectly linked API functions, ... . I created this PR to fix them.