Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galactic coordinates in scan map #164

Merged
merged 11 commits into from
May 1, 2022
Merged

Galactic coordinates in scan map #164

merged 11 commits into from
May 1, 2022

Conversation

paganol
Copy link
Member

@paganol paganol commented Apr 26, 2022

This PR addresses issue #137. I included the pointing rotation in the scan_map function and, I added some new functions in coordinates.py, they are mostly adapted from rotator.py of healpy.

@paganol paganol linked an issue Apr 26, 2022 that may be closed by this pull request
Add e2g rotation in scan_map #137
Closed
@paganol paganol requested review from ziotom78 and sgiardie April 26, 2022 18:29
ziotom78
ziotom78 requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@ziotom78 ziotom78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I have annotated a few changes to improve the clarity and robustness of the code.

@ziotom78 ziotom78 mentioned this pull request Apr 28, 2022
Merged
ziotom78
ziotom78 requested changes Apr 28, 2022
View reviewed changes
Copy link
Member

@ziotom78 ziotom78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me! The last thing that is still missing is to export the ECL_TO_GAL_ROT_MATRIX and CoordinateSystem symbols in litebird_sim/init.py, under the section for file coordinates.py, then it's ready to be merged.

ziotom78
ziotom78 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@ziotom78 ziotom78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! You can add a reference to this PR in the CHANGELOG and merge everything to master. We'll probably need to release a new version of the framework at that point.

@paganol
Copy link
Member Author

paganol commented Apr 29, 2022

We'll probably need to release a new version of the framework at that point.

Agree. I would just wait for the comparison that @giuspugl and @sgiardie are doing. If everything works fine we can release a new version.

@paganol paganol merged commit 42565b4 into master May 1, 2022
@paganol paganol deleted the fix137_e2g_scan_map branch May 1, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreineck mreineck mreineck left review comments

@ziotom78 ziotom78 ziotom78 approved these changes

@sgiardie sgiardie sgiardie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e2g rotation in scan_map
4 participants
@paganol @ziotom78 @mreineck @sgiardie