usb: PyUsbDevice addresses need to be strings

[nmalaguti]

The cli treats addresses as strings, but the USB address is an integer. It needs to be converted to a string for the comparison to work.

This also changes the output from --json status.

---

Checklist:

• Adhere to the development process
• Conform to the style guide
• Verify that the changes work as expected on real hardware
• Add automated tests cases
• Verify that all (other) automated tests (still) pass
• Update/add documentation
  • README, with "new/changed in" notes
  • applicable docs/*guide.md device guides, with "new/changed in" notes
  • liquidctl.8 Linux/Unix/Mac OS man page
  • protocol documentation in docs/developer/protocol
• Submit relevant data, scripts or dissectors to https://github.com/liquidctl/collected-device-data

New CLI flag?

• Adjust the completion scripts in extra/completions/

New device?

• Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
• Add entry to the README's supported device list with applicable notes and git MRLV

New driver?

• Document the protocol in docs/developer/protocol/

[jonasmalacofilho]

Nice catch.

Maybe

diff --git a/liquidctl/driver/usb.py b/liquidctl/driver/usb.py
index 27ff346f0f0a..fecacc283eae 100644
--- a/liquidctl/driver/usb.py
+++ b/liquidctl/driver/usb.py
@@ -376,7 +376,7 @@ class PyUsbDevice:
 
     @property
     def address(self):
-        return self.usbdev.address
+        return str(self.usbdev.address)
 
     @property
     def port(self):

could be a better fix for it, though.

Is it still enough to fix the real world issue for you?

[nmalaguti]

Is it still enough to fix the real world issue for you?

I'll test it out, but looking at the code almost certainly yes (and that's a better fix too).

[nmalaguti]

Confirmed the fix worked. It might be a small breaking change because the --json output now outputs the address as a string instead of a number.

[jonasmalacofilho]

It might be a small breaking change because the --json output now outputs the address as a string instead of a number.

Forgot about that... and it also breaks the public API. And even though the change is small, it will likely require downstream changes anyway, because listing and filtering devices is a very basic feature.

I'll take your original fix to avoid the unnecessary breaking changes. Thanks!

(I'll manually merge your original commit).