-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'Corsair H150i ELITE WH' #725
Conversation
If the maintainer(s) could help regenerate the udev rules that would be perfect. Somehow when I regenerate using the Python script I see more rule changes than the one I added for H150i:
|
Oh, they were out of sync on |
@@ -135,6 +135,8 @@ class HydroPlatinum(UsbHidDriver): | |||
{'fan_count': 2, 'fan_leds': 0}), | |||
(0x1b1c, 0x0c37, 'Corsair iCUE H150i Elite RGB', | |||
{'fan_count': 3, 'fan_leds': 0}), | |||
(0x1b1c, 0x0c41, 'Corsair iCUE H150i Elite RGB (White)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From your PR description, it seems that you don't think differentiating between the two variants is warranted, and I tend to agree. We could keep both descriptions identical, and only leave a comment that the second PID is for the white variant. But both approaches are valid, so let me know which you, as someone that owns the device, prefers.
(If you decide to change the description, please remember to regenerate the udev rules once again).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to keep "white" in the description, just so that if any user reports, the description will save some digging to find this device, and thus might have a slight chance for making it easier to debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. Merging, thanks!
Adds support for the white version of 'Corsair H150i Elite RGB'.
I don't know why the vendor does this, but it seems like they gave a different productID for the white variant of this AIO cooler:
Tried this fix and it seems to work: fan control, pump control and LEDs (via software, fixed color).
Fixes:
Closes:
Related: #559
Checklist:
docs/*guide.md
device guides, with "new/changed in" notesliquidctl.8
Linux/Unix/Mac OS man pagedocs/developer/protocol
New CLI flag?
extra/completions/
New device?
extra/linux/71-liquidctl.rules
(instructions in the file header)git
MRLVNew driver?
docs/developer/protocol/