Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'Corsair H150i ELITE WH' #725

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

thisiscam
Copy link
Contributor

Adds support for the white version of 'Corsair H150i Elite RGB'.

I don't know why the vendor does this, but it seems like they gave a different productID for the white variant of this AIO cooler:

$ lsusb
...
Bus 005 Device 004: ID 1b1c:0c41 Corsair H150i ELITE WH
...

Tried this fix and it seems to work: fan control, pump control and LEDs (via software, fixed color).

Fixes:
Closes:
Related: #559


Checklist:

New CLI flag?

  • Adjust the completion scripts in extra/completions/

New device?

  • Regenerate extra/linux/71-liquidctl.rules (instructions in the file header)
  • Add entry to the README's supported device list with applicable notes and git MRLV

New driver?

  • Document the protocol in docs/developer/protocol/

@thisiscam
Copy link
Contributor Author

If the maintainer(s) could help regenerate the udev rules that would be perfect. Somehow when I regenerate using the Python script I see more rule changes than the one I added for H150i:

diff --git a/extra/linux/71-liquidctl.rules b/extra/linux/71-liquidctl.rules
index 8abcb41..68f9f5f 100644
--- a/extra/linux/71-liquidctl.rules
+++ b/extra/linux/71-liquidctl.rules
@@ -464,6 +464,9 @@ SUBSYSTEMS=="usb", ATTRS{idVendor}=="1b1c", ATTRS{idProduct}=="0c36", TAG+="uacc
 # Corsair iCUE H150i Elite RGB
 SUBSYSTEMS=="usb", ATTRS{idVendor}=="1b1c", ATTRS{idProduct}=="0c37", TAG+="uaccess"
 
+# Corsair iCUE H150i Elite RGB (White)
+SUBSYSTEMS=="usb", ATTRS{idVendor}=="1b1c", ATTRS{idProduct}=="0c41", TAG+="uaccess"
+
 # Gigabyte RGB Fusion 2.0 5702 Controller
 SUBSYSTEMS=="usb", ATTRS{idVendor}=="048d", ATTRS{idProduct}=="5702", TAG+="uaccess"
 
@@ -494,7 +497,7 @@ SUBSYSTEMS=="usb", ATTRS{idVendor}=="1e71", ATTRS{idProduct}=="2001", TAG+="uacc
 # NZXT HUE 2 Ambient
 SUBSYSTEMS=="usb", ATTRS{idVendor}=="1e71", ATTRS{idProduct}=="2002", TAG+="uaccess"
 
-# NZXT Kraken 2023 (broken)
+# NZXT Kraken 2023
 SUBSYSTEMS=="usb", ATTRS{idVendor}=="1e71", ATTRS{idProduct}=="300e", TAG+="uaccess"
 
 # NZXT Kraken 2023 Elite (broken)

@jonasmalacofilho
Copy link
Member

If the maintainer(s) could help regenerate the udev rules that would be perfect. Somehow when I regenerate using the Python script I see more rule changes than the one I added for H150i:

Oh, they were out of sync on main. I just fixed them (there), the diff should be clean now...

@thisiscam thisiscam marked this pull request as ready for review August 5, 2024 00:59
@@ -135,6 +135,8 @@ class HydroPlatinum(UsbHidDriver):
{'fan_count': 2, 'fan_leds': 0}),
(0x1b1c, 0x0c37, 'Corsair iCUE H150i Elite RGB',
{'fan_count': 3, 'fan_leds': 0}),
(0x1b1c, 0x0c41, 'Corsair iCUE H150i Elite RGB (White)',
Copy link
Member

@jonasmalacofilho jonasmalacofilho Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your PR description, it seems that you don't think differentiating between the two variants is warranted, and I tend to agree. We could keep both descriptions identical, and only leave a comment that the second PID is for the white variant. But both approaches are valid, so let me know which you, as someone that owns the device, prefers.

(If you decide to change the description, please remember to regenerate the udev rules once again).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to keep "white" in the description, just so that if any user reports, the description will save some digging to find this device, and thus might have a slight chance for making it easier to debug.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Merging, thanks!

@jonasmalacofilho jonasmalacofilho merged commit 7637f17 into liquidctl:main Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants