Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #31: Initial support for Hybrid transport (iOS only, non persistent) #51

Merged
merged 25 commits into from
Jan 27, 2025

Conversation

AlfioEmanueleFresta
Copy link
Member

@AlfioEmanueleFresta AlfioEmanueleFresta commented Jan 5, 2025

An initial rough implementation of hybrid transport - formerly known as Cloud Assisted Bluetooth Low Energy, or caBLE.

Includes

  • Generates QR code for QR-initiated transactions
  • Adds WebAuthn example which prints QR code to terminal (examples/webauthn_cable.rs)
  • Adds submodule fork of snow (noise protocol framework) with NIST P-256 curve implementation, as required by CTAP spec (see Add support for NIST P-256 curve mcginty/snow#185)

Limitations and follow ups

@AlfioEmanueleFresta
Copy link
Member Author

@msirringhaus would love your thoughts if you have the time for a review. Will try and merge this by tomorrow EOD otherwise.

Copy link
Collaborator

@msirringhaus msirringhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things. I didn't do a full review if everything is according to the spec, though. I'm guessing, if it works, it can't be that wrong :)

@AlfioEmanueleFresta AlfioEmanueleFresta mentioned this pull request Jan 16, 2025
13 tasks
@AlfioEmanueleFresta
Copy link
Member Author

Thanks for your feedback @msirringhaus! Addressed your comments - I'll rebase and land tomorrow.

@AlfioEmanueleFresta AlfioEmanueleFresta merged commit eba0af3 into master Jan 27, 2025
4 checks passed
@AlfioEmanueleFresta AlfioEmanueleFresta deleted the cable branch January 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants