fix: MUI Theme Base CSS Styles #9636
Conversation
bnussman-akamai
changed the title
| @@ -42,6 +42,7 @@ const useStyles = makeStyles<void, 'linkItem'>()( | |||
| color: '#fff', | |||
| display: 'flex', | |||
| fontFamily: 'LatoWebBold', // we keep this bold at all times | |||
| fontSize: '1rem', | |||
There was a problem hiding this comment.
Fixes fontSize regression
| @@ -14,6 +14,7 @@ interface Props { | |||
| const useStyles = makeStyles()((theme: Theme) => ({ | |||
| container: { | |||
| backgroundColor: theme.bg.main, | |||
| fontSize: '1rem', | |||
There was a problem hiding this comment.
Fixes fontSize regression
There was a problem hiding this comment.
Thanks for working on this!
This is a PR that needs far more visual testing before approving (CC @cpathipa). We really need to pull the code and test in the browser until we have visual regression tools. I tested quickly and found regressions right away so I suspect there could be more.
|
|
Tbh, I can't see a different in font size in Alban's screenshot that 990e8a1 fixed and thought that table arrow was pointing to the typo in "Transferred". It looked wrong spelled as is, so I googled it. Two "r"s. (I'm sorry 😅 ) Edit: Ah. On second glance, I see the font size issue. |
|
Wait I'm confused... @abailly-akamai, what is the first screenschot suppose to show? |
|
@bnussman-akamai 🤣 the grid cells were misaligned |
|
Ah okay, my fault. Should be good then! (#9622) |
bnussman-akamai
added
Approved
Good catch! @abailly-akamai This is the standard practice I follow of running the code locally for every PR review. The first screenshot regression was not introduced with this PR, and I might have missed the font size of the tables at first glance (0.875rem vs 1rem) as I might mainly focused on background theme color. |
Description 📝
Major Changes 🔄
<CssBaseline />to mount base stylesPreview 📷
Before☹️
Screen.Recording.2023-09-05.at.9.31.14.PM.mov
After 😁
Screen.Recording.2023-09-05.at.9.30.37.PM.mov
How to test 🧪