feat: [M3-7035] - Add DC-specific pricing to Linode backups #9588

mjac0bs · 2023-08-24T16:35:33Z

Description 📝

Pricing for backups is now Region-dependent. This PR uses the mocked API response for the linode/types endpoint to get the correct price for a backup add-on with region_prices data.

Major Changes 🔄

With the dcSpecificPricing feature flag on and MSW on:

In the Linode Create flow, adding Backups as an Add-On displays DC-specific backup pricing based on the selected Region in the Add-Ons panel and the checkout summary.
On the Linode Details -> Backups tab:
- The enable backups empty state copy displays DC-specific backup pricing based on the Linode's region.
- On the Enable Backups confirmation dialog, copy displays correctly calculated DC-specific backup pricing based on the Linode's region.
On the Enable All Backups drawer:
- Total cost of backups, and each Linode's DC-specific backup price, is displayed and calculated correctly.
- Minor copy updates (removed "Confirm to add backups to N Linode(s)" and prefixed the total with "Total for N Linodes:")
- A Region column exists in the table with populated region data for each Linode
- Modal is widened to fit all four columns (existing + new Regions column)
Updated unit tests

Preview 📷

Flow/Component	Before	After
Linode Create
Linode Details -> Backups
Enable Backups Dialog
Backups Drawer

How to test 🧪

How to setup test environment?

Ensure the dcSpecificPricing feature flag is toggled on.
Turn the MSW on.

How to verify changes?

Make the changes described below to the mocks.
Test that this mocked linode in Jakarta has DC-specific backups pricing (should use mocked region_price) in all the locations mentioned in the table above.
Toggle the dcSpecificPricing flag off and confirm the mocked linode in Jakarta does not have any increases in its backup price (should use mocked base price).
Remove the region you added earlier from the mocked requestrest.get('*/linode/instances/:id' and confirm that a linode not in Jakarta or Sao Paulo does not have any increases in its backup price (should use mocked base price).
Ensure no new regressions in unit and e2e tests.

Update the MSW mocked requestrest.get('*/linode/instances/:id' to include region: 'id-cgk' in the mocked linode created with the factory.

To test Backups Drawer:
Recommend modifying rest.get('*/linode/instances' to use a shorter list of linodes:

      linodeFactory.build({
        backups: { enabled: false },
        label: 'eu-linode',
        region: 'eu-west',
      }),
      linodeFactory.build({
        backups: { enabled: false },
        label: 'DC-Specific Pricing Linode',
        region: 'id-cgk',
      }),

How to run Unit or E2E tests?

yarn test BackupLinodeRow utils AddOnsPanel linodes

mjac0bs · 2023-08-28T19:18:07Z

packages/manager/src/features/Linodes/LinodesCreate/LinodeCreateContainer.tsx

Backups pricing can no longer be calculated at this level because it is DC-dependent.

mjac0bs · 2023-08-28T19:20:51Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/EnableBackupsDialog.tsx

@@ -82,7 +90,7 @@ export const EnableBackupsDialog = (props: Props) => {
    >
      <Typography>
        Are you sure you want to enable backups on this Linode?{` `}
-        This will add <Currency quantity={price} />
+        This will add <Currency quantity={backupsMonthlyPrice ?? 0} />


It seems somewhat strange that we will display "This will add $0.00 to your account." if there is ever a linode that doesn't have a monthly backup price returned types, but this existing behavior, so I left it because it provides transparency, at least.

mjac0bs · 2023-08-28T19:23:41Z

packages/manager/src/utilities/pricing/linodes.ts

@@ -25,6 +25,31 @@ export const getLinodeRegionPrice = (
  return type.price;
 };

+/**


This was also added in Alban's PR. Kept consistent function and variable names here.

mjac0bs · 2023-08-28T19:24:47Z

packages/manager/src/features/Linodes/LinodesCreate/LinodeCreate.tsx

@@ -85,7 +90,6 @@ import {
 import type { Tab } from 'src/components/TabLinkList/TabLinkList';

 export interface LinodeCreateProps {
-  backupsMonthlyPrice?: null | number;


Again, this is no longer a prop because it is calculated in this component based on region selection.

bnussman-akamai

Very nice! Didn't find any issues with the flag on or off!

packages/manager/src/features/Backups/BackupDrawer.tsx

packages/manager/src/features/Backups/BackupLinodeRow.tsx

packages/manager/src/features/Backups/utils.ts

packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/EnableBackupsDialog.tsx

…ricing

packages/manager/src/utilities/pricing/backups.ts

mjac0bs · 2023-08-29T19:41:09Z

packages/manager/src/features/Linodes/LinodesCreate/AddonsPanel.tsx

+    return backupsMonthlyPrice && backupsMonthlyPrice > 0 ? (
+      <Typography variant="body1">
+        <Currency quantity={backupsMonthlyPrice} /> per month
+      </Typography>
+    ) : undefined;


Without the ternary, this will display "0" in the UI.

packages/manager/src/features/Backups/BackupLinodeRow.tsx

abailly-akamai

Looks good! happy to move utils around in upcoming work. Good to go 👍

packages/manager/src/utilities/pricing/linodes.test.tsx

packages/manager/src/utilities/pricing/backups.ts

packages/manager/src/features/Backups/utils.ts

packages/manager/src/features/Backups/utils.test.ts

mjac0bs · 2023-08-29T19:56:41Z

@abailly-akamai I'll merge now so you can rebase -- thank you for taking care of moving the util!

) * Add dynamic pricing backups util functions * Update Enable Backups drawer with dynamic pricing * Update Backups tab placeholder and confirmation dialog with dynamic pricing * Update mocks for now * Revert mock updates after rebase * Add test for backup price util function * Add DC-specific pricing to Linode Create flow * Update cached regions file to include Jakarta and Sao Paulo * Feature flag changes * Improve consistency with price variable names * Update tests * Renamed util function for consistency with linode#9570 * Added changeset: Add DC-specific pricing to Linode backups * Update backups drawer total cost util function to use FF * Address feedback: && over ternary * Address feedback: util and types * Missed a spot

mjac0bs added the DC-Specific Pricing label Aug 24, 2023

mjac0bs self-assigned this Aug 24, 2023

cpathipa added the Work in Progress label Aug 25, 2023

mjac0bs force-pushed the M3-7035-add-dc-pricing-to-linode-backups branch from 6737b64 to e3eb1a7 Compare August 28, 2023 14:08

mjac0bs marked this pull request as ready for review August 28, 2023 19:10

bnussman-akamai added the Ready for Review label Aug 28, 2023

mjac0bs removed the Work in Progress label Aug 28, 2023

mjac0bs requested review from bnussman-akamai and abailly-akamai August 28, 2023 19:10

mjac0bs commented Aug 28, 2023

View reviewed changes

bnussman-akamai approved these changes Aug 28, 2023

View reviewed changes

bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 28, 2023

abailly-akamai reviewed Aug 29, 2023

View reviewed changes

mjac0bs added 16 commits August 29, 2023 09:57

Add dynamic pricing backups util functions

6ab9251

Update Enable Backups drawer with dynamic pricing

fa634a4

Update Backups tab placeholder and confirmation dialog with dynamic p…

9cfa318

…ricing

Update mocks for now

adc3b9c

Revert mock updates after rebase

7adc1b8

Add test for backup price util function

59716a2

Add DC-specific pricing to Linode Create flow

4e61a6d

Update cached regions file to include Jakarta and Sao Paulo

0d173d5

Feature flag changes

362823e

Improve consistency with price variable names

b027cdb

Update tests

365714c

Renamed util function for consistency with linode#9570

c4347e6

Added changeset: Add DC-specific pricing to Linode backups

0076444

Update backups drawer total cost util function to use FF

0ebaa3f

Address feedback: && over ternary

e48bc7b

Address feedback: util and types

12a0f11

mjac0bs force-pushed the M3-7035-add-dc-pricing-to-linode-backups branch from bf44f9d to 12a0f11 Compare August 29, 2023 18:53

Missed a spot

58c8dc6

mjac0bs commented Aug 29, 2023

View reviewed changes

abailly-akamai approved these changes Aug 29, 2023

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 29, 2023

mjac0bs merged commit 7ddcf3d into linode:develop Aug 29, 2023

This was referenced Sep 5, 2023

Release v1.101.0 - release → staging #9627

Merged

Release v1.101.0 - staging → master #9633

Merged

mjac0bs mentioned this pull request Oct 12, 2023

feat: [M3-7063] - Provide dynamic price error handling for DC-specific pricing #9660

Merged

20 tasks

mjac0bs mentioned this pull request Nov 9, 2023

change, test: [M3-7073, M3-7176] - Remove dcSpecificPricing and objDcSpecificPricing feature flags #9881

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7035] - Add DC-specific pricing to Linode backups #9588

feat: [M3-7035] - Add DC-specific pricing to Linode backups #9588

mjac0bs commented Aug 24, 2023 •

edited

Loading

mjac0bs Aug 28, 2023

mjac0bs Aug 28, 2023

mjac0bs Aug 28, 2023

mjac0bs Aug 28, 2023

bnussman-akamai left a comment

mjac0bs Aug 29, 2023

abailly-akamai left a comment

mjac0bs commented Aug 29, 2023

feat: [M3-7035] - Add DC-specific pricing to Linode backups #9588

feat: [M3-7035] - Add DC-specific pricing to Linode backups #9588

Conversation

mjac0bs commented Aug 24, 2023 • edited Loading

Description 📝

Major Changes 🔄

Preview 📷

How to test 🧪

mjac0bs Aug 28, 2023

Choose a reason for hiding this comment

mjac0bs Aug 28, 2023

Choose a reason for hiding this comment

mjac0bs Aug 28, 2023

Choose a reason for hiding this comment

mjac0bs Aug 28, 2023

Choose a reason for hiding this comment

bnussman-akamai left a comment

Choose a reason for hiding this comment

mjac0bs Aug 29, 2023

Choose a reason for hiding this comment

abailly-akamai left a comment

Choose a reason for hiding this comment

mjac0bs commented Aug 29, 2023

mjac0bs commented Aug 24, 2023 •

edited

Loading