feat: [M3-7026] - AGLB Details - Service Targets Tab #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
approved these changes
Aug 23, 2023
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/LoadBalancerServiceTargets.tsx
Show resolved
Hide resolved
bnussman-akamai
added
Add'tl Approval Needed
mjac0bs
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Similar question to the Certificates tab PR! Can we document in a ticket if there are any UI components that will be added as a result of the action menu options? It looks like Edit will open the Create Service Target drawer, which may require a note/acceptance criteria on M3-7031 so that component handles both. The action menu is missing the Clone Service Target option - not sure if the intended behavior for that action will result in a dialog or not. Same with Delete -- any confirmation dialog?
Edit: (Just saw your comment on #9576 . :) Thanks!)
|
I'm waiting for signoff on the UI before I mess with the Jira tickets any more. Expect updates and new tickets soon! @mjac0bs |
mjac0bs
approved these changes
Aug 23, 2023
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/LoadBalancerServiceTargets.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/LoadBalancerServiceTargets.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
added
Approved
This was referenced Sep 5, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
* initial build * add cert field * Added changeset: Add AGLB Details - Service Targets Tab * make more responsive * improve search * feedback --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪
http://localhost:3000/loadbalancers/1/service-targets