-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6969] - Add DC-specific pricing to Kubernetes HA #9568
feat: [M3-6969] - Add DC-specific pricing to Kubernetes HA #9568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the env var go away 👋🏼
packages/manager/src/features/Kubernetes/CreateCluster/HAControlPlane.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not directly relevant to this PR, but it is a quick change to finalize this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me!
However I wanted to point to a difference in the UX that bothers me:
Before, adding a cluster in the create flow would
- disable the add button and reset the field to 0
- add the subtotal in the panel
Now, in the new flow, we only get item 1 and it's a pretty odd experience because one would expect something else to happen> i think it is confusing to the user. I know we still have the "Select a Region and Plan to create a cluster." sentence in there but it's super easy to miss and wonder if something is broken.
IMO it would make more sense to still add the items to the sidebar but not display the prices and the sentence for each item instead, OR at least adding a warning icon or something next to the empty sidebar sentence to make sure the user does not miss it.
Thoughts?
packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx
Show resolved
Hide resolved
@abailly-akamai - Yeah, this is fair. I've reached out to Matthew and Kendall for some feedback on this/overall UI changes when Region is not selected and are awaiting their input. I think either approach you suggested would work and improve the UX from what it is now. Here's my current thought: Screen.Recording.2023-08-21.at.1.48.40.PM.mov |
@abailly-akamai This is ready for re-review with a UX sign off on these changes from Kendall. Changes: In the checkout summary, without a Region selection, the total price is replaced with a message indicate Region and Node Pool selections are needed. Until Region is selected, users can still add Pools, but they won’t see pricing for it under each pool. Although the radio button label is long, this provides transparency and reiterates the need to make a Region selection. Removed the "Prices my vary based on Region" from the helper text above the options. At UX request, added HA as a line item to the Cluster Summary -- this was slightly out of scope of this PR, but an improvement upon #9489, so this change is not feature flagged. Also updated the helper text copy slightly to more accurately instruct the user to add a Node Pool.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thx for the changes!
* Delete unused files from refactor in linode#9489 * Add dynamic HA pricing for Kubernetes * Update unit tests * Add DC-specific HA price on upgrade dialog * Replace HA env var with pricing constant * Clean up * Added changeset: Add DC-specific pricing to Kubernetes HA * Don't display prices before region is selected * Tweak copy in Kube checkout bar * Update tests * Feature flag all changes and update tests * Update price increase percentage for Sao Paulo * Address feedback: eliminate prop and use hook * Address feedback: copy, UX for HA checkout bar
* Delete unused files from refactor in linode#9489 * Add dynamic HA pricing for Kubernetes * Update unit tests * Add DC-specific HA price on upgrade dialog * Replace HA env var with pricing constant * Clean up * Added changeset: Add DC-specific pricing to Kubernetes HA * Don't display prices before region is selected * Tweak copy in Kube checkout bar * Update tests * Feature flag all changes and update tests * Update price increase percentage for Sao Paulo * Address feedback: eliminate prop and use hook * Address feedback: copy, UX for HA checkout bar
Description 📝
High Availability (HA) pricing ($60.00/month per cluster for all DCs) is controlled through an environment variable in CI. This PR moves base pricing to a constant in the codebase and allows us to dynamically calculate HA pricing for new DCs.
Major Changes 🔄
LKE_HA_PRICE
) rather than theREACT_APP_LKE_HIGH_AVAILABILITY_PRICE
env var.Preview 📷
Screen.Recording.2023-08-20.at.3.31.12.PM.mov
How to test 🧪
Flows: