feat: [M3-6736] - VPC detail summary #9549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
approved these changes
Aug 18, 2023
bnussman-akamai
added
Add'tl Approval Needed
In the event that a user updates a VPC with a shorter description, is it expected for the layout to shift and for the "Read More" link to remain visible? |
jdamore-linode
approved these changes
Aug 18, 2023
bnussman-akamai
added
Approved
This was referenced Sep 5, 2023
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
## Description 📝 Add VPC Detail Summary section with Subnets placeholder ## How to test 🧪 ``` yarn test VPCDetail ``` ``` yarn test packages/manager/src/features/VPC/utils.test.ts ``` - Create a VPC, then go to it's details page and confirm the summary - If there is no description for the VPC, the description field should not display - If there is a description, you should see the field - Try editing/deleting the VPC --------- Co-authored-by: Joe D'Amore <jdamore@linode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add VPC Detail Summary section with Subnets placeholder
Preview 📷
How to test 🧪