upcoming: [M3-9499] - Maintenance policy types and queries #11990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…maintenance-types-and-queries
…maintenance-types-and-queries
hkhalil-akamai
changed the title
hkhalil-akamai
requested review from
harsh-akamai and
hasyed-akamai
and removed request for
a team
harsh-akamai
approved these changes
Apr 10, 2025
packages/api-v4/src/account/types.ts
Outdated
Comment on lines
397
to
400
| 'linode_migration', | ||
| 'linode_mutate_create', | ||
| 'linode_mutate', | ||
| 'linode_power_on_off', |
There was a problem hiding this comment.
Suggested change
| 'linode_migration', | |
| 'linode_mutate_create', | |
| 'linode_mutate', | |
| 'linode_power_on_off', | |
| 'linode_migrate', | |
| 'linode_mutate_create', | |
| 'linode_mutate', | |
| 'linode_poweroff_on', |
Event actions as mentioned in the APISpec, or am I missing something?
There was a problem hiding this comment.
I think you're correct, I will verify with the API development team.
There was a problem hiding this comment.
linode_migrate is an existing action type, so I was a little confused. I left a comment on the API spec for further clarification.
|
Hi @hkhalil-akamai, can you please resolve the merge conflicts before approving ! |
hkhalil-akamai
force-pushed
the
M3-9499-vm-host-maintenance-types-and-queries
branch
from
0b36319 to
cfd3008
Compare
hkhalil-akamai
requested review from
jdamore-linode
and removed request for
a team
hasyed-akamai
approved these changes
Apr 15, 2025
hasyed-akamai
added
Approved
…maintenance-types-and-queries
hkhalil-akamai
force-pushed
the
M3-9499-vm-host-maintenance-types-and-queries
branch
from
cfd3008 to
2ff2b09
Compare
|
Waiting for additional changes to the API spec before merging. |
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
…maintenance-types-and-queries
…maintenance-types-and-queries
Cloud Manager UI test results🔺 1 failing test on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts" |
|||||||||||||||||
|
Test failure appears unrelated. |
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds types, endpoints and query hooks for the Host & VM Maintenance Policy project.
Changes 🔄
API-v4
MaintenancePolicytypegetMaintenancePoliciesendpointEvent,MaintenanceandLinodetypes with new fields'Maintenance Policy'region capabilityManager
Preview 📷
How to test 🧪
Verify newly defined and updates types, keys, and queries follow our existing standards.
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅