BUGFIX Updating java_agrs to elephant.conf for resolving argument conflicts #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahrukhkhan489
changed the title
shahrukhkhan489
changed the title
akshayrai
suggested changes
Nov 9, 2017
app-conf/elephant.conf
Outdated
| @@ -27,7 +27,12 @@ enable_analytics=false | |||
|
|
|||
| # Additional Configuration | |||
| # Check https://www.playframework.com/documentation/2.2.x/ProductionConfiguration | |||
| jvm_props="-Devolutionplugin=enabled -DapplyEvolutions.default=true" | |||
| #jvm_props="-Devolutionplugin=enabled -DapplyEvolutions.default=true" | |||
There was a problem hiding this comment.
Remove this line. Not required.
app-conf/elephant.conf
Outdated
|
|
||
| # Adding the below line for Heap Tuning and Java OPTS | ||
| # mem - Heap Memory | ||
| jvm_args="-Devolutionplugin=enabled -DapplyEvolutions.default=true -mem 1024 -J-Xloggc:$project_root../logs/elephant/dr-gc.`date +'%Y%m%d%H%M'` -J-XX:+PrintGCDetails" |
There was a problem hiding this comment.
Is a slash missing here?
$project_root/..
There was a problem hiding this comment.
Nope Its not. $project_root itself has a / within it. So there is not point of mentioning one more /
akshayrai
approved these changes
Nov 10, 2017
skakker
pushed a commit
to skakker/dr-elephant
that referenced
this pull request
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fixes mentioned in #297.
jvm_argsinstead ofjvm_propsto enable Java Arguments-mem 1024to enable default Heap allocation of 1GB.-J-Xloggc:$project_root../logs/elephant/dr-gc.date +'%Y%m%d%H%M'-J-XX:+PrintGCDetailsto enable GC logging in the same directory of Dr. Elephant Logs