Fix connection pass through preventing functions from working #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogrogan
force-pushed
the
jogrogan/functionSupport
branch
from
ccf3285 to
62844e7
Compare
ryannedolan
approved these changes
Feb 24, 2025
| if (row.URL.endsWith("//")) { | ||
| joinedUrl = joinedUrl + joiner; | ||
| } else { | ||
| joinedUrl = joinedUrl + ";" + joiner; |
There was a problem hiding this comment.
The k1=v1;k2=v2 format seems to be a common convention, but not all drivers support it. We may run into drivers that choke on it. Not sure what to do in that case...
There was a problem hiding this comment.
All the drivers we have for now do support it, so maybe that's good enough for now? Considering Properties objects are always key/value pairs I'd imagine we'd run into more problems if we just had single values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues: