-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: failOnMissing
& failOnCompileError
for loaders + compiler
#2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8 tasks
size-limit report 📦
|
failOnMissing
& failOnCompileError
for loaders + compiler
andrii-bodnar
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timofei-iatsenko @hahn-kev thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #2193 #2192
This PR adds two new features for all places (except of Metro transformer, i later desribe way) where catalogs are compiled. Including:
lingui compile
commandMetro tranformer doesn't have a way to pass options for now, so these flags couldn't be implemented now FYI @vonovak
failOnMissing
Will fail build if there are missing translations. Useful to ensure production builds doesn't have missing translations
For vite & webpack this option should be passed directly to theirs config.
lingui compile
will perform this check when--strict
flag is passedfailOnCompileError
Will fail build if there are compilation errors for messages. For example, syntax issues in the ICU expressions.
When this flag is false it will still report these errors but as warnings.
For vite & webpack this option should be passed directly to theirs config.
lingui compile
will perform this check when--strict
flag is passedOther Changes
This PR might introduce some slight breaking changes for those who uses Lingui API directly.
I would prefer not to rise major version, because this should not affect users who just using lingui as usual.
createCompiledCatalog
returns{source: string, errors: MessageCompilationError[]}
instead ofstring
catalog.getTranslations
returns{messages: Messages, missing: TranslationMissingEvent[]}
instead ofMessages
Types of changes
Fixes # (issue)
Checklist