xilem_web: Add pointer events and fix bounds on event listeners and correct event type for mouse events. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect event type for mouse events.
|
Added some documentation for the |
viktorstrate
pushed a commit
to viktorstrate/xilem
that referenced
this pull request
Nov 10, 2024
…orrect event type for mouse events. (linebender#733) As [this Firefox issue](https://bugzilla.mozilla.org/show_bug.cgi?id=1675847) is finally fixed, we can be more close to the spec with the `click/auxclick/contextmenu` events by using a `PointerEvent` instead of a `MouseEvent`. I've also noticed that the DOM interface bounds/types were out of sync with the event types (bounds), this was corrected as well. Additionally all the `pointer...` events were added. And a simple `PointerMsg::position() -> Point` accessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this Firefox issue is finally fixed, we can be more close to the spec with the
click/auxclick/contextmenuevents by using aPointerEventinstead of aMouseEvent.I've also noticed that the DOM interface bounds/types were out of sync with the event types (bounds), this was corrected as well.
Additionally all the
pointer...events were added.And a simple
PointerMsg::position() -> Pointaccessor.