Remove manual recursion to child paint and accessibility
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursing is done inside the paint and accessibility passes since ff7635e.
tomcur
commented
Aug 26, 2024
Comment on lines
-19
to
-21
| .paint_fn(move |child, ctx, scene| { | ||
| child.paint(ctx, scene); | ||
| }) |
There was a problem hiding this comment.
Should this get at child paint (and maybe accessibility) in some other way?
There was a problem hiding this comment.
I don't think so - all that this paint implementation did was paint the child, which is now implicit/always the behaviour.
I think that this is fine.
DJMcNab
approved these changes
Aug 28, 2024
Comment on lines
-19
to
-21
| .paint_fn(move |child, ctx, scene| { | ||
| child.paint(ctx, scene); | ||
| }) |
There was a problem hiding this comment.
I don't think so - all that this paint implementation did was paint the child, which is now implicit/always the behaviour.
I think that this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursing is done inside the paint and accessibility passes since ff7635e. I believe this is the correct continuation of #522, with the removal of these methods "left for later" as mentioned in #522 (comment).
One note is that Flex now debug-paints its baseline under its children, rather than over them.