Add View::State and IdPath to xilem_masonry
#218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #220 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Alternative to #218 The version of viewsequence added in #205 is robust for all properties supported in that version. However, it would be incompatible with future expansions to the Xilem model, in particular async wiring. In this PR, I propose a system to resolve this, which uses generational indexes in the view id path (for the items where this is relevant). Some other historical record: #9 This brings back the `View::State` associated type (renamed to `ViewState` and `SeqState` depending on the trait), in order to perform this wiring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, to avoid (further) duplicate work.
Basically adds
View::Stateback toxilem_masonryand the id path, similar to how it was done before (i.e. distinct ids, which may be relevant for a robust async context).This is not yet 100% done (issues with changing
AnyViewcurrently).Also renames the generic params
StateandTtoAppStatefor clear distinction toView::State