Force encoding of transform/style following glyph run #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #424 which describes a case where encoding a glyph run breaks the optimization that omits duplicate transforms/styles from their respective streams. This uses flags in the encoding to force the next transform/style to be emitted. An alternative implementation would be to unconditionally encode a transform/style after each glyph run but this seemed like the better approach to me. Also changes SimpleText::add to use the glyph run API. This means all text in the vello demos now uses that code path rather than encoding glyph outlines directly.
dfrg
added a commit
to linebender/xilem
that referenced
this pull request
Jan 25, 2024
... and everything else, apparently. This pushes the new font code changes through the ecosystem. Brings everything into sync and should put us in a good place to start releasing. This works as is but depends on a vello commit that is still under review: linebender/vello#425 should land first and this should be updated with the new git rev before merging.
Philipp-M
approved these changes
Jan 26, 2024
|
Thanks Philipp! Your reviews across the whole range of projects have been incredibly helpful in moving these changes forward. |
github-merge-queue bot
pushed a commit
to linebender/xilem
that referenced
this pull request
Jan 26, 2024
* Update vello and parley deps... ... and everything else, apparently. This pushes the new font code changes through the ecosystem. Brings everything into sync and should put us in a good place to start releasing. This works as is but depends on a vello commit that is still under review: linebender/vello#425 should land first and this should be updated with the new git rev before merging. * fmt :( * update git revs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424 which describes a case where encoding a glyph run breaks the optimization that omits duplicate transforms/styles from their respective streams.
This uses flags in the encoding to force the next transform/style to be emitted. An alternative implementation would be to unconditionally encode a default transform/style after each glyph run but this seemed like the better approach to me.
Also changes SimpleText::add to use the glyph run API. This means all text in the vello demos now uses that code path rather than encoding glyph outlines directly.