Don't reset query pool twice #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoked in non robust memory mode (ie not using RenderDriver), both the render_coarse and render_fine calls reset the query pool, which in turn causes the fetch of the query pool to hang (in Vulkan). This is not an issue in robust memory mode because there are two different query pools, and both should indeed be reset. This patch makes the second reset conditional on the query pool being fresh. Fixes an observed hang with the xilem prototype on Windows.
dfrg
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoked in non robust memory mode (ie not using RenderDriver), both the render_coarse and render_fine calls reset the query pool, which in turn causes the fetch of the query pool to hang (in Vulkan).
This is not an issue in robust memory mode because there are two different query pools, and both should indeed be reset.
This patch makes the second reset conditional on the query pool being fresh.
Fixes an observed hang with the xilem prototype on Windows.